Verify COMPOSER_VENDOR_DIR in conditional
#71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pick up milestone creation step Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
This corrects an issue where `COMPOSER_VENDOR_DIR` could be an empty value and this condition erroneously runs. Before running this condition we need to confirm `COMPOSER_VENDOR_DIR` is set and contains a value. For further details on this issue see: - craftcms/cms#6773 - laminas/laminas-feed#22
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
weierophinney
force-pushed
the
patch-1
branch
from
461003c
to
0e8e803
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This corrects an issue where
COMPOSER_VENDOR_DIRcould be an empty value and this condition erroneously runs. Before running this condition we need to confirmCOMPOSER_VENDOR_DIRis set and contains a value.For further details on this issue see: